Bad object expression created when using anonymous import & runtime resolution #14
Comments
PCreations
added a commit
to PCreations/babel-plugin-react-css-modules
that referenced
this issue
Dec 14, 2016
…to escape properties' name (gajus#14)
PCreations
added a commit
to PCreations/babel-plugin-react-css-modules
that referenced
this issue
Dec 14, 2016
…to escape properties' name (gajus#14)
This was referenced Dec 14, 2016
PCreations
changed the title
gajus
pushed a commit
that referenced
this issue
Dec 18, 2016
…#13 #14 #17) (#12) * fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution
|
Fixed in #12. Thank you @PCreations |
gajus
pushed a commit
that referenced
this issue
Dec 19, 2016
* fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: className attribute is now correctly generated when using runtime resolution (#18)
gajus
pushed a commit
that referenced
this issue
Jan 6, 2017
* Make syntax parser configurable * Make syntax parser configurable * fix: handle multiple file import with dynamic resolution (fixes #7 #11 #13 #14 #17) (#12) * fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: generate className when using runtime resolution (#18) (#19) * fix: added escape hatch when testing attribute that do not have a name property (#11) * fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14) * fix: getClassName now works as expected when multiple file use runtime resolution * fix: getClassName now works as expected when multiple file use runtime resolution * fix: className attribute is now correctly generated when using runtime resolution (#18) * feat: improve error messages (#21) * Make syntax parser configurable * Merged upstream * Updated the configuration section of the readme file * docs: improve wording * fix: add a missing comma BREAKING CHANGE: If your installation is using CSS, now you need to manually install scss-loader and configure it. https://github.com/gajus/babel-plugin-react-css-modules#configurate-syntax-loaders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using dynamic resolution with anonymous import, the generated object expression by
createObjectExpression.jsdoes not return a valid AST since the generated property name is prefixed byrandom-and the hypen is not "escaped" by quotes.The text was updated successfully, but these errors were encountered: