Adding unsupported hot reload #12683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature. |
|
@phunkeler thank you for the correction :D |
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
phunkeler
reviewed
Feb 12, 2025
| @@ -50,3 +50,11 @@ using SentrySession = Sentry.Session; | |||
| ``` | |||
|
|
|||
| Then `SentrySession` can be used instead of `Sentry.Session`. | |||
|
|
|||
| ### VS Hot Restart isn't compatible with static assemblies | |||
There was a problem hiding this comment.
- ### VS Hot Restart isn't compatible with static assemblies
+ ### Visual Studio Hot Restart Limitation- ### VS Hot Restart isn't compatible with static assemblies
+ ### Visual Studio Hot Restart IncompatibilityA bit more concise.
|
|
||
| > The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed. | ||
|
|
||
| This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations). |
There was a problem hiding this comment.
@aritchie curious, nothing we can do about this?
People need to uninstall Sentry to use Hot Restart?
There was a problem hiding this comment.
@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases
There was a problem hiding this comment.
Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously
There was a problem hiding this comment.
There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.
Thoughts
<PackageReference Include="Sentry.Maui" Condition="$(HOT_RESTART) == 'false'" />#if !HOTRESTART
.UseSentry(...)
#endif
phunkeler
reviewed
Feb 13, 2025
coolguyzone
approved these changes
Feb 13, 2025
codyde
added a commit
that referenced
this pull request
Feb 27, 2025
* master: (45 commits) feat: Mention that the cookie-sync extension works for previews (#12858) ref(flags): update unleashIntegration param (#12795) ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801) docs(python): Clarify how to init SDK in `async` app (#12854) move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786) docs(span-links): Add develop docs for span links (#12829) feat(java): add Reactor integration docs (#12686) Add Quarkus to community maintained SDKs (#12834) Adding unsupported hot reload (#12683) Fix broken links (#12844) feat(python): Clarification regarding start_transaction (#12835) docs(flutter): Fix event serverName reset in samples (#12832) ref(insights): move performance docs under insights (#12720) Bump API schema to 2e61347a (#12836) fix(apple): Usages of sendDefaultPii (#12833) Add `sendDefaultPii: true` to React Native init code snippets (#12812) Only show Browser vs React Native source maps alert for browser sdks (#12816) Add Data Collected page for React Native (#12811) Fix React Native Onboarding Option Buttons (#12813) Add Hono guide (#12710) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.
Closes getsentry/sentry-dotnet#3959