Skip to content

Add Data Collected page for React Native #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Feb 24, 2025

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): 24. Feb
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 1:25pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 1:25pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 1:25pm

Copy link

codecov bot commented Feb 24, 2025

Bundle Report

Changes will increase total bundle size by 216 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB 222 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json 77 bytes 379.38kB 0.02%
../app/platform-redirect/page.js.nft.json 77 bytes 379.3kB 0.02%
../app/sitemap.xml/route.js.nft.json 77 bytes 377.27kB 0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/x2kJ5UQwOM5n6zBPpx1Ez/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/x2kJ5UQwOM5n6zBPpx1Ez/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/WXouvI8lzbs_ju74q3hOw/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/WXouvI8lzbs_ju74q3hOw/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) February 25, 2025 13:11
@krystofwoldrich krystofwoldrich merged commit 3168025 into master Feb 25, 2025
11 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-rn-add-data-collected branch February 25, 2025 13:25
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
  feat: Mention that the cookie-sync extension works for previews (#12858)
  ref(flags): update unleashIntegration param (#12795)
  ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
  docs(python): Clarify how to init SDK in `async` app (#12854)
  move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
  docs(span-links): Add develop docs for span links (#12829)
  feat(java): add Reactor integration docs (#12686)
  Add Quarkus to community maintained SDKs (#12834)
  Adding unsupported hot reload (#12683)
  Fix broken links (#12844)
  feat(python): Clarification regarding start_transaction (#12835)
  docs(flutter): Fix event serverName reset in samples (#12832)
  ref(insights): move performance docs under insights (#12720)
  Bump API schema to 2e61347a (#12836)
  fix(apple): Usages of sendDefaultPii (#12833)
  Add `sendDefaultPii: true` to React Native init code snippets (#12812)
  Only show Browser vs React Native source maps alert for browser sdks (#12816)
  Add Data Collected page for React Native (#12811)
  Fix React Native Onboarding Option Buttons (#12813)
  Add Hono guide (#12710)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documents and Use sendDefaultPii=true in docs and in product getting started guide
3 participants