Skip to content

fix(apple): Usages of sendDefaultPii #12833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

philipphofmann
Copy link
Member

DESCRIBE YOUR PR

Document the only usage of sendDefaultPii in the Cocoa SDK. See Cocoa SDK.

Fixes GH-12751

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Document the only usage of sendDefaultPii in the Cocoa SDK.

Fixes GH-12751
@philipphofmann philipphofmann self-assigned this Feb 25, 2025
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 2:18pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Feb 25, 2025 2:18pm
develop-docs ⬜️ Ignored (Inspect) Feb 25, 2025 2:18pm

@kahest kahest self-requested a review February 25, 2025 14:07
@kahest kahest removed their assignment Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.19MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.38MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.04kB -0.0%
static/chunks/4028-*.js -3 bytes 393.29kB -0.0%
static/_tGnNEwBxCfMvNfBqLiPE/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/_tGnNEwBxCfMvNfBqLiPE/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/xd-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/xd-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.46MB -0.0%
../instrumentation.js -3 bytes 791.26kB -0.0%
9523.js -3 bytes 767.46kB -0.0%

@kahest kahest merged commit fb0e761 into master Feb 25, 2025
11 checks passed
@kahest kahest deleted the fix/apple-usage-of-send-default-pii branch February 25, 2025 16:54
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
  feat: Mention that the cookie-sync extension works for previews (#12858)
  ref(flags): update unleashIntegration param (#12795)
  ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
  docs(python): Clarify how to init SDK in `async` app (#12854)
  move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
  docs(span-links): Add develop docs for span links (#12829)
  feat(java): add Reactor integration docs (#12686)
  Add Quarkus to community maintained SDKs (#12834)
  Adding unsupported hot reload (#12683)
  Fix broken links (#12844)
  feat(python): Clarification regarding start_transaction (#12835)
  docs(flutter): Fix event serverName reset in samples (#12832)
  ref(insights): move performance docs under insights (#12720)
  Bump API schema to 2e61347a (#12836)
  fix(apple): Usages of sendDefaultPii (#12833)
  Add `sendDefaultPii: true` to React Native init code snippets (#12812)
  Only show Browser vs React Native source maps alert for browser sdks (#12816)
  Add Data Collected page for React Native (#12811)
  Fix React Native Onboarding Option Buttons (#12813)
  Add Hono guide (#12710)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple: Document Data Collected
2 participants