forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Modernize localize script, use new XML library #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c19997
to
9028920
Compare
0489765
to
884c29f
Compare
9028920
to
6d3661d
Compare
884c29f
to
9cfb18f
Compare
6d3661d
to
b066bd6
Compare
9cfb18f
to
0405877
Compare
b066bd6
to
1f08f8c
Compare
0405877
to
d804da9
Compare
1f08f8c
to
072f98b
Compare
d804da9
to
dc0dcaa
Compare
072f98b
to
497c663
Compare
dc0dcaa
to
5dd52e5
Compare
497c663
to
792b782
Compare
5dd52e5
to
41f5a32
Compare
792b782
to
0f369f3
Compare
41f5a32
to
704dac1
Compare
0f369f3
to
9f5b4d3
Compare
704dac1
to
6a78836
Compare
9f5b4d3
to
751f57a
Compare
6a78836
to
56f8ef7
Compare
751f57a
to
6578dbb
Compare
56f8ef7
to
b71e8b2
Compare
6578dbb
to
48673d2
Compare
b71e8b2
to
f3bd118
Compare
48673d2
to
c148de0
Compare
724c1ce
to
06fd201
Compare
c28d68c
to
a9b166d
Compare
06fd201
to
2dd50e5
Compare
a9b166d
to
b52815c
Compare
2dd50e5
to
1c5adef
Compare
b52815c
to
8431802
Compare
1c5adef
to
f228ffc
Compare
8431802
to
57d2fef
Compare
f228ffc
to
fd3428a
Compare
57d2fef
to
f73c69a
Compare
fd3428a
to
01839d2
Compare
f73c69a
to
b033d0c
Compare
01839d2
to
294e719
Compare
b033d0c
to
9f8832c
Compare
294e719
to
8ad35b2
Compare
9f8832c
to
25e6634
Compare
8ad35b2
to
7618a69
Compare
25e6634
to
6e69116
Compare
7618a69
to
c7d69f5
Compare
6e69116
to
6715a98
Compare
c7d69f5
to
0c12baa
Compare
6715a98
to
c497480
Compare
0c12baa
to
37eeaba
Compare
c497480
to
058b59f
Compare
37eeaba
to
6a92bb1
Compare
This file is pretty much the same as it was when it was committed in 2017; these days, we can write clearer code with async/await and new FS APIs. Additionally, we can improve the performance of this script by using a newer/faster/maintained XML library. This will enable us to run the script unconditionally in a later commit.
058b59f
to
fe08021
Compare
6a92bb1
to
958c796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is pretty much the same as it was when it was committed in
2017; these days, we can write clearer code with async/await and new FS
APIs.
Additionally, we can improve the performance of this script by using a
newer/faster/maintained XML library. This will enable us to run the
script unconditionally in a later commit.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: