8329717: Missing @since tags in elements in DocumentationTool and Taglet

[nizarbenalla]

In this PR I added an @since tag to SNIPPET_PATH and isBlockTag() as they were added in later versions

• SNIPPET_PATH was added in JDK 18 here

• isBlockTag() was added in JDK 15 here

This is similar to #18032

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329717: Missing @<!---->since tags in elements in DocumentationTool and Taglet (Bug - P4)

Reviewers

• Pavel Rappo (@pavelrappo - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18640/head:pull/18640
$ git checkout pull/18640

Update a local copy of the PR:
$ git checkout pull/18640
$ git pull https://git.openjdk.org/jdk.git pull/18640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18640

View PR using the GUI difftool:
$ git pr show -t 18640

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18640.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329717: Missing `@since` tags in elements in DocumentationTool and Taglet

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 281 new commits pushed to the master branch:

• ee7b2e9: 8330051: Small ObjectMonitor spinning code cleanups
• 3e185c7: 8330154: Serial: Remove TenuredSpace::update_for_block
• f889797: 8330463: Rename invalidate() to write_region() in ModRefBarrierSet
• c4f5c51: 8330576: ZYoungCompactionLimit should have range check
• 70acade: 8330339: G1: Move some public methods to private in G1BlockOffsetTable APIs
• 35b30c8: 8330595: Invoke ObjectMethods::bootstrap method exactly
• 3d62bbf: 8330681: Explicit hashCode and equals for java.lang.runtime.SwitchBootstraps$TypePairs
• 5313dcc: 8330733: Generational ZGC: Remove ZBarrier::verify_old_object_live_slow_path
• 5394f57: 8330621: Make 5 compiler tests use ProcessTools.executeProcess
• 20546c1: 8330004: Refactor cloning down code in Split If for Template Assertion Predicates
• ... and 271 more: https://git.openjdk.org/jdk/compare/70c8ff1c9a9adf21a16d8a6b4da1eeec65afe61d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@pavelrappo) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@nizarbenalla The following labels will be automatically applied to this pull request:

• compiler
• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0c5a300d)
• 00: Full (0ffee115)

[pavelrappo]

Looks good. Thanks.

[pavelrappo]

Might as well insert a blank line above.

[nizarbenalla]

Done, looking at the existing source code sometimes I find a blank line and sometimes I don't.

[pavelrappo]

Understood; my comment was a mild suggestion, not a requirement. I find it easier to read when @since is set off with a blank line.

[openjdk]

@nizarbenalla
Your change (at version 0c5a300) is now ready to be sponsored by a Committer.

[openjdk]

@jonathan-gibbons This PR has not yet been marked as ready for integration.

[jonathan-gibbons]

@nizarbenalla You need to fix the PR summary to agree with the JBS summary.

[jonathan-gibbons]

/sponsor

[openjdk]

Going to push as commit 83c74d7.
Since your change was applied there have been 286 commits pushed to the master branch:

• 0b9350e: 8322992: Javac fails with StackOverflowError when compiling deeply nested synchronized blocks
• 20be5e0: 8314846: Do not store Klass::_secondary_super_cache in CDS archive
• 7e421ce: 8330585: Refactor/rename forwardee handling
• 3e65d90: 8330820: Remove remnants of operator_new.cpp in build system
• 936a47d: 8330607: Deprecate -XX:+UseEmptySlotsInSupers
• ee7b2e9: 8330051: Small ObjectMonitor spinning code cleanups
• 3e185c7: 8330154: Serial: Remove TenuredSpace::update_for_block
• f889797: 8330463: Rename invalidate() to write_region() in ModRefBarrierSet
• c4f5c51: 8330576: ZYoungCompactionLimit should have range check
• 70acade: 8330339: G1: Move some public methods to private in G1BlockOffsetTable APIs
• ... and 276 more: https://git.openjdk.org/jdk/compare/70c8ff1c9a9adf21a16d8a6b4da1eeec65afe61d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons @nizarbenalla Pushed as commit 83c74d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.