Subtree update of `rust-analyzer` #121931

lnicola · 2024-03-03T07:18:13Z

`get_path_for_executable` will now first check `$CARGO_HOME` before falling back to searching `$PATH`. rustup is the recommended way to manage rust toolchains, therefore should be picked before the system toolchain.

internal: sync from downstream

update bug report issue template

…kril Document nvim 0.10 `inlay_hint` It took me a few hours to figure out how to enable inlay type hints on Nvim 0.10 with `lspconfig`. `rustaceanvim` has already dropped support for them (mrcjkb/rustaceanvim#46 (comment)) and most other plugins, like `rust-tools`, are depreciated in favor of `rustaceanvim`. This PR documents how to enable the inlay hints on Neovim 0.10 and later. I've tested this and changing the `on_attach` function is the only step that is required.

…r=Veykril Prioritise rustup sysroots over system ones `get_path_for_executable` will now first check `$CARGO_HOME` before falling back to searching `$PATH`. `rustup` is the recommended way to manage rust toolchains, therefore should be picked before the system toolchain. Closes rust-lang#16661

…, r=Veykril Merge `BorrowKind::Unique` into `BorrowKind::Mut` Resolves rust-lang#15170

…xt_with_find_map, r=Veykril fix: replace_filter_map_next_with_find_map shouldn't work for dyn trait close rust-lang/rust-analyzer#16596

Narrow down typos ignores - remove ignored files - check dotfiles - reorder config sections: files, regexp, words, IDs - remove non-existent ignores

fix: Fix modules in blocks not resolving in ide layer Fixes rust-lang/rust-analyzer#16511

internal: Remove salsa compile_fail tests I can't figure out how to reproduce them, but hopefully fixes these: ![image](https://github.com/rust-lang/rust-analyzer/assets/308347/462dbfc3-5414-42fd-b81d-a3d699fa9a8d)

fix: panic when inlining callsites inside macros' parameters Close rust-lang#16660, rust-lang#12429, rust-lang#10695. When `inline_into_callers` encounters callsites in macros parameters, it can lead to panics. Since there is no perfect way to handle macros, this PR directly filters out these cases.

internal: Remove load-cargo dependency on ide This lightens up the dep tree for projects using r-a as a library that do not need the ide crate itself.

Export `SemanticsImpl` from `ra_ap_hir` crate, since it's already exposed via `Semantics.deref()` The `SemanticsImpl` type is already de-facto exposed via `<Semantics as Deref>::Target`. By not being part of the public crate interface it however doesn't get included in the documentation, resulting in a massive blind spot when it comes to `ra_ap_hir`'s type resolution APIs.

minor: Move span stuff around

fix: Don't highlight related assoc items of super traits

minor: Remove outdated comment about static SmolStrs Closes rust-lang/rust-analyzer#16734

internal: Simplify

…ykril fix: Ignore generic arguments in intra doc link path resolution Fixes rust-lang/rust-analyzer#16699

…m-ra

rustbot · 2024-03-03T07:18:17Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2024-03-03T07:18:58Z

@bors r+ p=1 subtree sync

bors · 2024-03-03T07:19:00Z

📌 Commit 964e769 has been approved by lnicola

It is now in the queue for this repository.

bors · 2024-03-03T09:07:25Z

⌛ Testing commit 964e769 with merge 1090205...

bors · 2024-03-03T11:33:14Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 1090205 to master...

rust-timer · 2024-03-03T12:47:22Z

Finished benchmarking commit (1090205): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[5.3%, 5.3%]	1
Improvements ✅ (primary)	-6.0%	[-6.0%, -6.0%]	1
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-6.0%	[-6.0%, -6.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.052s -> 648.889s (-0.18%)
Artifact size: 175.05 MiB -> 175.06 MiB (0.01%)

Young-Flash and others added 30 commits February 21, 2024 18:07

update bug report issue template

f610e7c

add repository link entry

689fa20

fix: replace_filter_map_next_with_find_map shouldn't work for dyn trait

4220f90

add test case

0978d16

make clippy happy

b132190

add assist for filling fields by replacing ellipsis in record syntax

6f4354f

prioritise rustup sysroots over system ones

9f1d4aa

`get_path_for_executable` will now first check `$CARGO_HOME` before falling back to searching `$PATH`. rustup is the recommended way to manage rust toolchains, therefore should be picked before the system toolchain.

Merge branch 'master' into sync-from-rust

fb31610

Auto merge of rust-lang#16668 - lnicola:sync-from-rust, r=lnicola

5346002

internal: sync from downstream

Merge BorrowKind::Unique into BorrowKind::Mut

a336bdc

Document nvim 0.10 inlay_hint

ea837d1

Add note

4060377

Auto merge of rust-lang#16627 - Young-Flash:issue_template, r=Veykril

309e087

update bug report issue template

Auto merge of rust-lang#16669 - ShoyuVanilla:merge-borrow-kind-unique…

e1983d2

…, r=Veykril Merge `BorrowKind::Unique` into `BorrowKind::Mut` Resolves rust-lang#15170

internal: move strip_references into dyn trait check

fd0cddf

internal: format code

7a58a23

Auto merge of rust-lang#16647 - Young-Flash:fix_replace_filter_map_ne…

8929853

…xt_with_find_map, r=Veykril fix: replace_filter_map_next_with_find_map shouldn't work for dyn trait close rust-lang/rust-analyzer#16596

fix:do not handle callsites in macros' parameters

36298c6

test: callsites inside inline_into_callers

38a50cf

Remove salsa compile_fail tests

1ef7a99

Narrow down typos ignores

1880117

Auto merge of rust-lang#16673 - szepeviktor:patch-1, r=lnicola

2251d06

Narrow down typos ignores - remove ignored files - check dotfiles - reorder config sections: files, regexp, words, IDs - remove non-existent ignores

fix: Fix modules in blocks not resolving in ide layer

91554e0

Auto merge of rust-lang#16679 - Veykril:block-mod, r=Veykril

40bf8bf

fix: Fix modules in blocks not resolving in ide layer Fixes rust-lang/rust-analyzer#16511

fix: fmt

61b576c

Add a new failing test

7637141

bors and others added 17 commits February 29, 2024 14:59

Auto merge of rust-lang#16706 - Veykril:load-cargo-ide-db, r=Veykril

b3b9b53

internal: Remove load-cargo dependency on ide This lightens up the dep tree for projects using r-a as a library that do not need the ide crate itself.

Give all threads names

83a1ad5

Fix targetDir config name

c8fdcea

Simplify

ed7e9aa

fix: Don't highlight related assoc items of super traits

aabaa47

minor: Add some basic docs for spans/hygiene handling

eb7a4f2

Only the ROOT syntax context has None outer_expn

8a5bb9d

Add a few more doc lines to the span crate

549aae7

Move AstIdMap infra to the span crate

efd76ec

Auto merge of rust-lang#16728 - Veykril:span-docs, r=Veykril

c512e2e

minor: Move span stuff around

Auto merge of rust-lang#16727 - Veykril:assoc-related, r=Veykril

79e0fee

fix: Don't highlight related assoc items of super traits

Remove outdated comment about static SmolStrs

dd21914

Auto merge of rust-lang#16735 - lnicola:smolstr-new-static, r=lnicola

6cb576a

minor: Remove outdated comment about static SmolStrs Closes rust-lang/rust-analyzer#16734

Auto merge of rust-lang#16704 - Veykril:stuff, r=Veykril

5c4c126

internal: Simplify

Auto merge of rust-lang#16702 - Veykril:intra-doc-links-generic, r=Ve…

4ef6a49

…ykril fix: Ignore generic arguments in intra doc link path resolution Fixes rust-lang/rust-analyzer#16699

Merge commit '4ef6a49b44e8aa380da7522442234bfd7a52c55e' into sync-fro…

964e769

…m-ra

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 3, 2024

bors merged commit 1090205 into rust-lang:master Mar 3, 2024

rustbot added this to the 1.78.0 milestone Mar 3, 2024

lnicola deleted the sync-from-ra branch March 3, 2024 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #121931

Subtree update of `rust-analyzer` #121931

lnicola commented Mar 3, 2024

rustbot commented Mar 3, 2024

lnicola commented Mar 3, 2024

bors commented Mar 3, 2024

bors commented Mar 3, 2024

bors commented Mar 3, 2024

rust-timer commented Mar 3, 2024

Subtree update of rust-analyzer #121931

Subtree update of rust-analyzer #121931

Conversation

lnicola commented Mar 3, 2024

rustbot commented Mar 3, 2024

lnicola commented Mar 3, 2024

bors commented Mar 3, 2024

bors commented Mar 3, 2024

bors commented Mar 3, 2024

rust-timer commented Mar 3, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Subtree update of `rust-analyzer` #121931

Subtree update of `rust-analyzer` #121931