-
Notifications
You must be signed in to change notification settings - Fork 11
V.next #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mark Dostal <[email protected]>
updated authenticator and doc
It used to be in two places, not it is used once in `SiteAndFacilitySelector.getter:body`
Per design doc
Per design
This reverts commit 5edfa5b.
Update FloorFilterExampleView.swift
This reverts commit 24ae75d.
Co-authored-by: David Feinzimer <[email protected]>
change auth example's target to be 15.0 and fix build issue with latest sdk
[UN Trace] - Rename `viewPoint` to `screenPoint`, support viewpoint animation, make proxy a non-binding property
Co-authored-by: Mark Dostal <[email protected]>
Co-authored-by: Philip Ridgeway <[email protected]>
[Compass] Re-think API
Viewpoint changes should always be reported to the model, despite whether the site and facility selector is open or not.
[Compass] Remove `action` parameter, add `mapViewProxy` parameter, support rotation animation
It was only called from one spot at this point and doesn't carry enough weight as its own function
[Floor Filter] Fix automatic selection in compact width
[Bookmarks] Fix animation in example
dfeinzimer
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the
v.next
branch intomain
for the v200.1.0 release. Everything has already been reviewed, this is just a "sanity-check".