-
Notifications
You must be signed in to change notification settings - Fork 190
doc: Merges CLOUDP-274025 docs & examples branch - DONT MERGE YET #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luster (#3043) * doc: Adds initial structure for module example cluster_to_advanced_cluster * chore: fix lint errors * refactor: directory move * doc: Initial module_user * doc: Remove hcl simplification purpose (most likely done only in module_maintainer) * Update examples/migrate_cluster_to_advanced_cluster/module_maintainer/README.md Co-authored-by: Leo Antoli <[email protected]> * address PR comments --------- Co-authored-by: Leo Antoli <[email protected]>
* root readme * fix example as used region doesn't exist in GCP * change examples * undo comment * doc for backing_provider_name
…ce and data sources (#3048) * add doc references at the beginning of the doc * examples * replace replication_specs.# * leftover * connection_strings * Move and other changes * rename schema to preview * ds * fix defaultMaxTimeMS links * fix typo region_config * Update docs/data-sources/advanced_clusters (preview v2).md Co-authored-by: carriecwk <[email protected]> * Update docs/resources/advanced_cluster.md Co-authored-by: carriecwk <[email protected]> * apply feedback --------- Co-authored-by: carriecwk <[email protected]>
* null default value * org id
* master: doc: Renames env var to `MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER` (#3062) chore: Updates Atlas Go SDK (#3053) test: Tenant clusters with disk_size_gb is always 5 now (#3057) chore: Updates CHANGELOG.md for #3051 fix: Removes `interval_min` plan modifier to avoid error on update (#3051) build(deps): bump go.mongodb.org/atlas-sdk (#3049) doc: Adds pinned_fcv.version as exported attribute in cluster and advanced cluster resource (#3047) update Go to 1.23.6 (#3045) chore: Adds HTTP status check helper methods (#3035) chore: Adds import checks to tests (#3039) chore: Updates CHANGELOG.md header for v1.26.1 release chore: Updates examples link in index.md for v1.26.1 release fix: Adds "state_name" to keepUnknown list to prevent copying volatile attributes from state (#3040)
…CLUSTER` (#3064) * rename env. var. to MONGODB_ATLAS_PREVIEW_PROVIDER_V2_ADVANCED_CLUSTER * change example doc * update links and menu items * fix links * change style
…3050) * initial v2 & v3 implementations * Adds `v2` Implementation Changes and Highlights * doc: Update README with v3 implementation changes and highlights * doc: Update README and add v1_v2 and v3 variable files for cluster migration examples * style: fmt * doc: Fix v3 usage of cluster data source * feat: Add output for MongoDB connection strings in v1, v2, and v3 examples * style: fmt * chore: Enable Advanced Cluster V2 Schema validation in tf-validate script * fix lint errors * feat: Add function to check for V2 schema directories in tf-validate script * refactor: Use approach 1 (file headings) rather than a table * address PR comments * docs: Update README files to enhance migration guidance for mongodbatlas_cluster to mongodbatlas_advanced_cluster * address PR comments * chore: Update ToC * Review suggestions * update var name * docs: Enhance README to clarify standalone usage and upgrade support for module_maintainer * fix: Update required_version comment for clarity in versions.tf files * docs: Add v3_no_plan_changes and step for ensuring no changes when using new `replication_specs_new` variable * update var name to make tf-validate pass * fix: Update environment variable for Terraform validation in v2 schema * docs: Update ToC * fix: update restore command in tf-validate script to use preview_provider_v2.go
…las_advanced_cluster` (#3058) * doc: Adds migration example from `mongodbatlas_cluster` to `mongodbatlas_advanced_cluster` * rename directory and example * chore: use a Note to warn about creating a `mongodbatlas_cluster` and more details * add review suggestions * support using v2 schema in basic
…nced_cluster preview provider v2 (#3071) * new guide * update docs * some adjustements * typos * feedback * best practices feedback * fix identation
…les (#3065) * handle todos * doc: Fix link in README for replication_specs in advanced cluster migration example * doc: Enhance variable descriptions in migration examples * doc: Update descriptions for outputs * doc: Change regions_config type from set to list in replication_specs variable (otherwise priority order failure) * doc: Change regions_config type from set to list in replication_specs variable (otherwise priority order failure)
* remove part about state * add doc about using the env var locally
* doc: Updates table formatting * clarify how to migrate * change order * move block section down * apply feedback * Update docs/guides/cluster-to-advanced-cluster-migration-guide.md Co-authored-by: Marco Suma <[email protected]> --------- Co-authored-by: Leo Antoli <[email protected]> Co-authored-by: Marco Suma <[email protected]>
* master: chore: Temporary fix on tenant cluster test passing zone name explicitly (#3078) exempt dependencies PR labels from being stale (#3073) use helper methods (#3072) chore: Bump golangci/golangci-lint-action from 6.3.0 to 6.5.0 (#3074) chore: Bump goreleaser/goreleaser-action from 6.1.0 to 6.2.1 (#3056)
APIx bot: a message has been sent to Docs Slack channel |
Merged
13 tasks
marcosuma
reviewed
Feb 18, 2025
marcosuma
reviewed
Feb 18, 2025
examples/migrate_cluster_to_advanced_cluster/module_maintainer/README.md
Outdated
Show resolved
Hide resolved
examples/mongodbatlas_advanced_cluster (preview provider v2)/asymmetric-sharded-cluster/main.tf
Outdated
Show resolved
Hide resolved
...ongodbatlas_advanced_cluster (preview provider v2)/version-upgrade-with-pinned-fcv/README.md
Outdated
Show resolved
Hide resolved
examples/migrate_cluster_to_advanced_cluster/module_user/README.md
Outdated
Show resolved
Hide resolved
examples/migrate_cluster_to_advanced_cluster/module_maintainer/README.md
Outdated
Show resolved
Hide resolved
marcosuma
reviewed
Mar 6, 2025
marcosuma
reviewed
Mar 6, 2025
oarbusi
reviewed
Mar 7, 2025
oarbusi
reviewed
Mar 7, 2025
oarbusi
reviewed
Mar 7, 2025
oarbusi
reviewed
Mar 7, 2025
oarbusi
reviewed
Mar 7, 2025
oarbusi
reviewed
Mar 7, 2025
examples/migrate_cluster_to_advanced_cluster/module_maintainer/v1/versions.tf
Outdated
Show resolved
Hide resolved
oarbusi
reviewed
Mar 7, 2025
examples/migrate_cluster_to_advanced_cluster/module_user/v1/versions.tf
Outdated
Show resolved
Hide resolved
oarbusi
reviewed
Mar 7, 2025
Co-authored-by: Oriol <[email protected]>
Co-authored-by: Oriol <[email protected]>
marcosuma
reviewed
Mar 7, 2025
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
themantissa
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all was addressed! Thank you team!!
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges CLOUDP-274025 docs & examples branch.
DONT MERGE YET
Type of change:
Required Checklist:
Further comments