Skip to content

N17: macroquad #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2021
Merged

N17: macroquad #424

merged 3 commits into from
Jan 12, 2021

Conversation

not-fl3
Copy link
Contributor

@not-fl3 not-fl3 commented Jan 5, 2021

No description provided.

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, but there's a few formatting things tripping up the CI build:

content/posts/newsletter-017/index.md:115:103 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
content/posts/newsletter-017/index.md:115:81 MD013/line-length Line length [Expected: 80; Actual: 103]
content/posts/newsletter-017/index.md:117:267 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
content/posts/newsletter-017/index.md:117:81 MD013/line-length Line length [Expected: 80; Actual: 267]
content/posts/newsletter-017/index.md:119:209 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 3]
content/posts/newsletter-017/index.md:119:81 MD013/line-length Line length [Expected: 80; Actual: 211]

You're also missing the URL for your miniquad link, by the looks of it.

@not-fl3 not-fl3 force-pushed the macroquad branch 3 times, most recently from f24ad70 to 12ae49e Compare January 6, 2021 17:38
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@ozkriff ozkriff mentioned this pull request Jan 8, 2021
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (made a few style & fmt tweaks)

@ozkriff ozkriff merged commit 164d8ef into rust-gamedev:source Jan 12, 2021
@ozkriff
Copy link
Member

ozkriff commented Jan 12, 2021

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants