Skip to content

Add note on Apache issue with FallbackResource #10433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3,197 commits into from
Sep 19, 2019
Merged

Conversation

pavlakis
Copy link
Contributor

@pavlakis pavlakis commented Oct 3, 2018

There was an Apache bug with FallbackResource when being called on the home page / causing Apache to hang. This is a difficult issue to debug and hence would be helpful to add a note here.
The Apache bug details can be found here: https://bz.apache.org/bugzilla/show_bug.cgi?id=58292

@javiereguiluz
Copy link
Member

@pavlakis thanks a lot for helping us improve docs. However, I've checked and Apache 2.4.25, the last version suffering this problem, was released on December 2016.

We usually don't add notes for old software ... except if that "old" version is popular for some reason (e.g. because some Linux distribution ships with it by default). So, do you think this "old" Apache version is popular enough these days? Thanks!

@pavlakis
Copy link
Contributor Author

pavlakis commented Oct 4, 2018

@javiereguiluz I don't have any stats to give you. However, looking at the Ubuntu distro, 16.04 which was the first to include PHP 7, is an LTS and it ships with Apache 2.4.18. As an LTS, it means 5 years support.
Most people will upgrade their PHP version but only upgrade their web server when upgrading the OS.
But again, I have no metrics to support the last comment.

xabbuh and others added 26 commits August 9, 2019 09:41
So I'm now a Symfony contributor right? 😏
This PR was merged into the 4.3 branch.

Discussion
----------

Adding missing semicolon

So I'm now a Symfony contributor right? 😏

Commits
-------

4946c67 Adding missing semicolon
…to show how to tick checkboxes (LucileDT)

This PR was merged into the 3.4 branch.

Discussion
----------

Add in the DOM crawler documentation code sample to show how to tick checkboxes

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

ab4715e Add in the DOW crawler documentation code sample to show how to tick checkboxes
* 3.4:
  Add in the DOW crawler documentation code sample to show how to tick checkboxes
  Adds the most basic informations about loaders
  [symfony#12075] fix some casing
  [Contributing] Add more information on deprecations
The script ask for the generation of logout, so add this information to the doc too
…ny Flex (javiereguiluz)

This PR was squashed before being merged into the 4.3 branch (closes symfony#12119).

Discussion
----------

Updated related to Symfony installation and Symfony Flex

Don't merge this yet ... because it needs some changes in symfony.com/download too.

-----

I think the new docs are better because:

* Symfony Local Server articles only talks about server, not security:check and creating apps.
* Flex is explained in the main setup article ... and /setup/flex is left as the article explaining how to upgrade old apps to Flex
* We now talk about "Install Symfony", to simplify the explanations around "the Symfony binary", which in the past we called it "binary", "CLI", "server", "local server", etc.
* The main setup + installation article shows Composer installation too, to avoid issues for people who can't install Symfony.
* We only have a single place where we show how to create Symfony apps with the Symfony binary and Composer (the main /setup article) instead of showing that in multiple places.
* We remove some internal details about Flex recipes which are already explained in the recipes repository.

Commits
-------

e614ed1 Updated related to Symfony installation and Symfony Flex
This PR was merged into the 4.3 branch.

Discussion
----------

Update security.yml use auto for encoding

Commits
-------

df9ec7a Update security.yml use auto for encoding
This PR was merged into the 4.3 branch.

Discussion
----------

Use :: instead of code block php

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

99a9d9c Use :: instead of code block php
This PR was merged into the 4.3 branch.

Discussion
----------

Fix path

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

7c1551a Fix path
This PR was squashed before being merged into the 4.3 branch (closes symfony#12114).

Discussion
----------

Revamped the routing documentation

The Symfony Docs team has decided to reorganize all the routing articles and create a single reference article explaining all the common routing features.

This PR merges several small files into the main `/routing.rst` article and I'll merge other small articles very soon. Meanwhile you can start reviewing these changes. Thank you!

Commits
-------

1268ba7 Revamped the routing documentation
…as annotations (andreybolonin, weaverryan)

This PR was submitted for the 4.1 branch but it was merged into the 4.3 branch instead (closes symfony#10201).

Discussion
----------

[Routing] Update routing.rst, add example routes as annotations

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

54743d6 cleaning up some use statements, etc
0a1badf Update routing.rst
…uiluz)

This PR was merged into the 4.3 branch.

Discussion
----------

Minor fixes for the new Routing article

Commits
-------

e95edab Minor fixes for the new Routing article
javiereguiluz and others added 20 commits September 18, 2019 09:12
…ation article (javiereguiluz)

This PR was merged into the 4.3 branch.

Discussion
----------

Mention the getParameter() helper in the configuration article

Fixes symfony#8996.

Commits
-------

d8e43b9 Mention the getParameter() helper in the configuration article
…n a single article (javiereguiluz)

This PR was squashed before being merged into the 4.3 branch (closes symfony#12317).

Discussion
----------

[Doctrine] Put all docs about testing databases in a single article

In addition to merging articles ... we know fully explain the super useful DAMADoctrineTestBundle created by our friend @dmaicher.

Commits
-------

986df88 [Doctrine] Put all docs about testing databases in a single article
…cs (javiereguiluz)

This PR was squashed before being merged into the 3.4 branch (closes symfony#12310).

Discussion
----------

Removed the cache.adapter.array mention in 3.4 docs

Fixes symfony#12222.

Commits
-------

cbbea6f Removed the cache.adapter.array mention in 3.4 docs
* 3.4:
  Removed the cache.adapter.array mention in 3.4 docs
…ion:update command (javiereguiluz)

This PR was merged into the 4.3 branch.

Discussion
----------

Minor improvement for the docs about the translation:update command

After merging symfony#12136, I realized we don't explain this command well ... so let's tweak it.

Commits
-------

182d927 Minor improvement for the docs about the translation:update command
…viereguiluz)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] Add the buffer option to 4.3 too

After merging symfony#12043 I realized we need to document it in 4.3 too.

Commits
-------

c82e6b8 [HttpClient] Add the buffer option to 4.3 too
…s attribute in DOM crawler page (LucileDT)

This PR was merged into the 3.4 branch.

Discussion
----------

Add doc about how to get a link by its id or class attribute in DOM crawler page

Commits
-------

48f8437 Add doc about how to get a link by its id or class attribute in DOM crawler page
* 3.4:
  Add doc about how to get a link by its id or class attribute in DOM crawler page
…uting annotations (javiereguiluz)

This PR was squashed before being merged into the 4.3 branch (closes symfony#12336).

Discussion
----------

[Routing] Better explain the config needed for routing annotations

Fixes symfony#12218.

Commits
-------

790b04c [Routing] Better explain the config needed for routing annotations
…ortInterface (Nyholm)

This PR was submitted for the master branch but it was squashed and merged into the 4.3 branch instead (closes symfony#12340).

Discussion
----------

[Messenger] Added an implementation to the TransportInterface

This will fix symfony#12230

This is basically a much simpler `DoctrineTransport` with easy query builders and no real error handling.

Commits
-------

e1c669b [Messenger] Added an implementation to the TransportInterface
…ticated() function (javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Tweaked the explanation about the is_fully_authenticated() function

Fixes symfony#10688.

Commits
-------

0c121a1 Tweaked the explanation about the is_fully_authenticated() function
* 3.4:
  Tweaked the explanation about the is_fully_authenticated() function
@javiereguiluz
Copy link
Member

I found these stats (not sure how reliable they are) and it looks like lots of people are using an Apache version with this issue: https://w3techs.com/technologies/details/ws-apache/2.4/all

So, let's merge this. I'm sorry it took us so long, but I completely forgot about this. Sorry.

There was an Apache bug with FallbackResource when being called on the home page `/` causing Apache to hang. This is a difficult issue to debug and hence would be helpful to add a note here.
The Apache bug details can be found here: https://bz.apache.org/bugzilla/show_bug.cgi?id=58292
@javiereguiluz javiereguiluz changed the base branch from 4.1 to 4.3 September 19, 2019 14:55
javiereguiluz added a commit that referenced this pull request Sep 19, 2019
This PR was submitted for the 4.1 branch but it was merged into the 4.3 branch instead (closes #10433).

Discussion
----------

Add note on Apache issue with FallbackResource

There was an Apache bug with FallbackResource when being called on the home page `/` causing Apache to hang. This is a difficult issue to debug and hence would be helpful to add a note here.
The Apache bug details can be found here: https://bz.apache.org/bugzilla/show_bug.cgi?id=58292

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

0f7a705 Add note on Apache issue with FallbackResource
@javiereguiluz javiereguiluz merged commit 0f7a705 into symfony:4.3 Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.