Skip to content

feat: blitz (2nd round) #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 21, 2025
Merged

feat: blitz (2nd round) #1853

merged 21 commits into from
Mar 21, 2025

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Mar 20, 2025 •
edited
Loading

Description

Pull request merging all the developments performed during the second blitz of the year. Full review of all addressed changes required.

Tasks

  • Revert CI/CD file changes - the original one should prevail
  • Verify proper usage of version decorators and backwards-compatible changes
  • Ensure proper testing is in place for all API
  • Ensure docstrings are properly documented
  • Submit cleanup PR (PENDING)

Issue linked

None

RobPasMue and others added 14 commits March 12, 2025 14:18
@RobPasMue
ci: simplify blitz ci
e07aeb3
@RobPasMue @pyansys-ci-bot
fix: translating sketch issues when using a custom default unit (#1808)
4e2eeb3 
Co-authored-by: pyansys-ci-bot <[email protected]>
@umutsoysalansys @pyansys-ci-bot @RobPasMue
feat: matrix helper methods (#1806)
22bb08f 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
@RobPasMue @pyansys-ci-bot
fix: edge start and end were not being mapped correctly (#1816)
5515312 
Co-authored-by: pyansys-ci-bot <[email protected]>
@RobPasMue
ci: use proper runner
ce21ad6
@jacobrkerstetter @RobPasMue
@pyansys-ci-bot @umutsoysalansys @pre-commit-ci
feat: component name setting (#1820)
c7ec5d8 
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Umut Soysal <[email protected]>
Co-authored-by: Jacob Kerstetter <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@b-matteo @RobPasMue
@pyansys-ci-bot @umutsoysalansys
feat: update api geometry dependency (#1834)
d2b7537 
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Umut Soysal <[email protected]>
@jacobrkerstetter @RobPasMue
@pyansys-ci-bot @pre-commit-ci
feat: enhanced beam implementation (#1828)
6339ea8 
Co-authored-by: Jacob Kerstetter <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jonahrb @pyansys-ci-bot
@RobPasMue @umutsoysalansys
feat: enable runscript for CoreService (#1821)
04ffd1b 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: Umut Soysal <[email protected]>
@mlkaplan36 @pyansys-ci-bot
@pre-commit-ci @RobPasMue @umutsoysalansys
feat: Streaming upload support (#1779)
3bea3ed 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: Umut Soysal <[email protected]>
@RobPasMue @pyansys-ci-bot
build: ansys api geometry 0.4.49 (#1840)
3835d66 
Co-authored-by: pyansys-ci-bot <[email protected]>
@jacobrkerstetter @RobPasMue
@pyansys-ci-bot @pre-commit-ci
feat: revolve faces and revolve faces by helix options (#1842)
d3fcc9d 
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Jacob Kerstetter <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@RobPasMue @pyansys-ci-bot
fix: tessellation options were not extended to component/face methods (…
371d89a 
…#1850)

Co-authored-by: pyansys-ci-bot <[email protected]>
@smereu @pyansys-ci-bot
@RobPasMue @pre-commit-ci
feat: Remove rounds (#1851)
d902047 
Co-authored-by: PyAnsys CI Bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@RobPasMue RobPasMue self-assigned this Mar 20, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.18750% with 73 lines in your changes missing coverage. Please review.

Project coverage is 89.96%. Comparing base (8bb7af7) to head (d874b97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 30.00% 21 Missing ⚠️
src/ansys/geometry/core/designer/beam.py 81.25% 18 Missing ⚠️
src/ansys/geometry/core/misc/options.py 60.00% 10 Missing ⚠️
src/ansys/geometry/core/modeler.py 73.33% 8 Missing ⚠️
src/ansys/geometry/core/designer/design.py 71.42% 6 Missing ⚠️
src/ansys/geometry/core/tools/prepare_tools.py 78.57% 3 Missing ⚠️
src/ansys/geometry/core/designer/face.py 60.00% 2 Missing ⚠️
src/ansys/geometry/core/connection/launcher.py 50.00% 1 Missing ⚠️
src/ansys/geometry/core/designer/component.py 97.22% 1 Missing ⚠️
src/ansys/geometry/core/math/matrix.py 94.73% 1 Missing ⚠️
... and 2 more

❌ Your project status has failed because the head coverage (89.96%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
+ Coverage   88.55%   89.96%   +1.40%     
==========================================
  Files          92       92              
  Lines        8575     8847     +272     
==========================================
+ Hits         7594     7959     +365     
+ Misses        981      888      -93

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label Mar 20, 2025
pyansys-ci-bot and others added 2 commits March 20, 2025 13:45
@pyansys-ci-bot
chore: adding changelog file 1853.added.md [dependabot-skip]
d801c35
@jacobrkerstetter @pre-commit-ci @pyansys-ci-bot
fix: named selection import test (#1854)
88fb082 
Co-authored-by: Jacob Kerstetter <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
@RobPasMue RobPasMue added the enhancement New features or code improvements label Mar 20, 2025
RobPasMue
RobPasMue commented Mar 20, 2025
View reviewed changes
Copy link
Member Author

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review on my side... opening a PR to fix the identified issues

@RobPasMue
Copy link
Member Author

Waiting for reviews on @jonahrb and @b-matteo before opening another PR that would fix the various issues identified.

b-matteo
b-matteo previously approved these changes Mar 21, 2025
View reviewed changes
@RobPasMue RobPasMue mentioned this pull request Mar 21, 2025
Merged
9 tasks
@RobPasMue @pyansys-ci-bot
chore: cleanup blitz PR (#1855)
d874b97 
Co-authored-by: pyansys-ci-bot <[email protected]>
@RobPasMue RobPasMue marked this pull request as ready for review March 21, 2025 10:58
@RobPasMue RobPasMue requested a review from a team as a code owner March 21, 2025 10:58
@RobPasMue RobPasMue enabled auto-merge (squash) March 21, 2025 10:58
@RobPasMue RobPasMue disabled auto-merge March 21, 2025 11:52
@RobPasMue RobPasMue merged commit bd3b65d into main Mar 21, 2025
46 of 48 checks passed
@RobPasMue RobPasMue deleted the blitz branch March 21, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-matteo b-matteo b-matteo left review comments

Assignees

@RobPasMue RobPasMue

Labels
enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RobPasMue @b-matteo @umutsoysalansys @jacobrkerstetter @jonahrb @mlkaplan36 @smereu @pyansys-ci-bot