Feature branches/forms #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated radio button tests * added test doc link
* slight edits to FeatureForm composable function KDoc. * Update toolkit/featureforms/src/main/java/com/arcgismaps/toolkit/featureforms/FeatureForm.kt Co-authored-by: Gunther Heppner <[email protected]> --------- Co-authored-by: Soren Roth <[email protected]> Co-authored-by: Gunther Heppner <[email protected]>
Co-authored-by: Soren Roth <[email protected]>
* update exception name for API change * update exception name for API change * pull in the build of the SDK with the name change of IncorrectValueTypeException --------- Co-authored-by: Soren Roth <[email protected]>
* use geo-compose in FeatureFormsApp. * remove DI providing MapViewProxy. add AndroidViewModel usage --------- Co-authored-by: Soren Roth <[email protected]>
… range. (#376) * do not pass a selected date into date picker if it is out of range. * just expand the year range to incloude out of range field value's date * add an initialError property to the DateTimePickerState, weave it through to the PickerHeader. * use includeTime and adjust spacing. --------- Co-authored-by: Soren Roth <[email protected]>
Co-authored-by: Soren Roth <[email protected]>
Co-authored-by: Soren Roth <[email protected]>
…sdk-kotlin-toolkit into feature-branches/forms
Co-authored-by: Soren Roth <[email protected]>
* wip * basic support for attachment element state creation and management * remove unused dependency --------- Co-authored-by: Soren Roth <[email protected]>
sorenoid
approved these changes
Jun 25, 2024
puneet-pdx
approved these changes
Jun 25, 2024
|
thanks @sorenoid @puneet-pdx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #4172
Description:
FeatureForm attachments api has been approved and this PR brings in the bulk of the attachments related toolkit changes.
Summary of changes:
FeatureForm.defaultAttachmentsElementto render anAttachmentFormElement.AttachmentElementStateprovides the state logic for theAttachmentFormElement.AttachmentTilewhich usesFormElementState.AttachmentsFileProviderprovides a way to share and view any attachment type with the default system apps.FeatureForm.finishEditing()api instead oftable.updateFeature()to save any form updates.GroupElementTestsandThemingTests.CalculatedFieldTeststhat verifies any fields with value expressions as indicated by the newFieldFormElement.hasValueExpressionproperty.ReadOnlyTextField.Pre-merge Checklist