Skip to content

Maintenance/upgrades and tooling #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 22, 2020

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 5, 2020

What do these changes do?

scripts and recipes

  • updates scripts to generate invitations ( template is WIP)
  • make autoformat now sort imports and black-formats your project files <--- WARNING: addictive!
    • applies to web/server service

python requirements

  • upgrades ujson from 2.0.3 to 3.0.0 (merges Bump ujson from 2.0.3 to 3.0.0 in /packages/service-library #1544) in webserver
  • upgrades ONLY test-requirements for all packages (e.g. tools like pytest, pylint, mocks, ... etc)
  • upgrades ONLY test requirements for web-server
  • upgrades to pylint==2.5.3 in ALL packages and web-server
  • pytest-cov 2.9.0->2.10.0
  • pytest-instafail 0.4.1.post0 -> 0.4.2

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov self-assigned this Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #1546 into master will increase coverage by 3.1%.
The diff coverage is 97.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1546     +/-   ##
========================================
+ Coverage    69.3%   72.4%   +3.1%     
========================================
  Files         281     281             
  Lines       10751   10751             
  Branches     1168    1168             
========================================
+ Hits         7455    7794    +339     
+ Misses       2971    2617    -354     
- Partials      325     340     +15     
Flag Coverage Δ
#integrationtests 57.4% <95.5%> (+2.0%) ⬆️
#unittests 65.0% <97.8%> (ø)
Impacted Files Coverage Δ
...erver/src/simcore_service_api_server/core/redoc.py 63.1% <0.0%> (ø)
...erver/src/simcore_service_webserver/__version__.py 100.0% <ø> (ø)
...src/simcore_service_webserver/activity/__init__.py 100.0% <ø> (ø)
.../server/src/simcore_service_webserver/db_models.py 100.0% <ø> (ø)
...rver/src/simcore_service_webserver/email_config.py 100.0% <ø> (ø)
...er/src/simcore_service_webserver/login/__init__.py 93.1% <ø> (ø)
.../src/simcore_service_webserver/login/decorators.py 100.0% <ø> (ø)
...er/src/simcore_service_webserver/login/settings.py 0.0% <ø> (ø)
...er/src/simcore_service_webserver/security_roles.py 100.0% <ø> (ø)
...mcore_service_webserver/socketio/handlers_utils.py 92.5% <ø> (ø)
... and 36 more

@pcrespov pcrespov force-pushed the maintenance/upgrades-n-tools branch 2 times, most recently from df8b7f5 to ce63803 Compare June 6, 2020 14:08
@pcrespov pcrespov marked this pull request as ready for review June 6, 2020 14:09
@pcrespov pcrespov marked this pull request as draft June 6, 2020 14:09
@pcrespov pcrespov force-pushed the maintenance/upgrades-n-tools branch from ce63803 to c1ca931 Compare June 8, 2020 12:48
@pcrespov pcrespov marked this pull request as ready for review June 8, 2020 12:52
@pcrespov pcrespov changed the title WIP: Maintenance/upgrades and tooling Maintenance/upgrades and tooling Jun 8, 2020
@pcrespov pcrespov requested review from GitHK, sanderegg and odeimaiz and removed request for GitHK June 8, 2020 12:53
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov force-pushed the maintenance/upgrades-n-tools branch from bb6ecb3 to da0336b Compare June 22, 2020 11:39
@pcrespov pcrespov merged commit 294611d into ITISFoundation:master Jun 22, 2020
@pcrespov pcrespov deleted the maintenance/upgrades-n-tools branch June 22, 2020 17:55
@odeimaiz odeimaiz mentioned this pull request Aug 4, 2020
odeimaiz added a commit that referenced this pull request Aug 4, 2020
- UI/UX improvements (#1657)
- Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665)
- Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664)
- Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647)
- Improving storage performance (#1659)
- Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642)
- Theming (#1656)
- Platform stability:  (#1645)
- is1594 fix and re-activate e2e testing (#1620)
- 2 bugs fixed + Some improvements (#1634)
- Fixes default (#1640)
- Bump lodash from 4.17.15 to 4.17.19 (#1639)
- Is1585/cleanup storage (#1586)
- Fixes on publish studies handling (#1632)
- Some enhancements and bug fixes (#1608)
- Improve e2e  (#1631)
- filter studies by name before deleting them (#1629)
- Maintenance/upgrades test tools (#1628)
- Bugfix/concurent opening projects (#1598)
- Bugfix/allow reading groups anonymous user (#1615)
- Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605)
- fix testing if node has gpu support (#1604)
- [bugfix] Invalidate cache before starting a study (#1602)
- Feature/fix e2e 2 (#1600)
- fix deploy not needing e2e testing since it is disabled
- reduce cardinality of metrics (#1593)
- Excudes e2e stage from include until fixed (#1595)
- Shared project concurrency (frontend) (#1591)
- Homogenize studies and services (#1569)
- [feature] UI Fine grained access - project locking and notification
- Bugfix/apiserver does not need sslheaders (#1564)
- Cleanup catalog service (#1582)
- Maintenance/cleanup api server (#1578)
- Adds support for GPU scheduling of computational services (#1553)
- Maintenance/upgrades and tooling (#1546)
- Is1570/study fails 500 (#1572)
- Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573)
- maintenance fix codecov reports (#1568)
- Manage groups, Share studies (#1512)
- Is/add notebook migration script (#1565)
- Is1269/api-server upgrade (#1475)
- added simcore_webserver_service in pytest simcore package (#1563)
- add traefik endpoint to api-gateway (#1555)
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants