Skip to content

[bugfix] Invalidate cache before starting a study #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 3, 2020

What do these changes do?

This PR fixes a bug with the cached studies in the fronted by making sure the latest version is fetched before starting it.

Bonus

  • Do not allow negative node position values

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #1602 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1602     +/-   ##
========================================
- Coverage    73.7%   73.6%   -0.1%     
========================================
  Files         278     278             
  Lines       10874   10874             
  Branches     1181    1181             
========================================
- Hits         8015    8014      -1     
- Misses       2516    2517      +1     
  Partials      343     343             
Flag Coverage Δ
#integrationtests 56.6% <ø> (ø)
#unittests 67.3% <ø> (ø)
Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 62.8% <0.0%> (-0.3%) ⬇️

@odeimaiz odeimaiz requested a review from sanderegg July 3, 2020 15:51
@odeimaiz odeimaiz changed the title [bugfix] [bugfix] Invalidate cache before starting a study Jul 3, 2020
@odeimaiz odeimaiz requested review from ignapas, pcrespov and Surfict July 3, 2020 15:53
@odeimaiz odeimaiz merged commit 47b24c6 into ITISFoundation:master Jul 3, 2020
@odeimaiz odeimaiz deleted the feature/ui-ux-2 branch July 17, 2020 15:45
@odeimaiz odeimaiz mentioned this pull request Aug 4, 2020
odeimaiz added a commit that referenced this pull request Aug 4, 2020
- UI/UX improvements (#1657)
- Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665)
- Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664)
- Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647)
- Improving storage performance (#1659)
- Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642)
- Theming (#1656)
- Platform stability:  (#1645)
- is1594 fix and re-activate e2e testing (#1620)
- 2 bugs fixed + Some improvements (#1634)
- Fixes default (#1640)
- Bump lodash from 4.17.15 to 4.17.19 (#1639)
- Is1585/cleanup storage (#1586)
- Fixes on publish studies handling (#1632)
- Some enhancements and bug fixes (#1608)
- Improve e2e  (#1631)
- filter studies by name before deleting them (#1629)
- Maintenance/upgrades test tools (#1628)
- Bugfix/concurent opening projects (#1598)
- Bugfix/allow reading groups anonymous user (#1615)
- Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605)
- fix testing if node has gpu support (#1604)
- [bugfix] Invalidate cache before starting a study (#1602)
- Feature/fix e2e 2 (#1600)
- fix deploy not needing e2e testing since it is disabled
- reduce cardinality of metrics (#1593)
- Excudes e2e stage from include until fixed (#1595)
- Shared project concurrency (frontend) (#1591)
- Homogenize studies and services (#1569)
- [feature] UI Fine grained access - project locking and notification
- Bugfix/apiserver does not need sslheaders (#1564)
- Cleanup catalog service (#1582)
- Maintenance/cleanup api server (#1578)
- Adds support for GPU scheduling of computational services (#1553)
- Maintenance/upgrades and tooling (#1546)
- Is1570/study fails 500 (#1572)
- Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573)
- maintenance fix codecov reports (#1568)
- Manage groups, Share studies (#1512)
- Is/add notebook migration script (#1565)
- Is1269/api-server upgrade (#1475)
- added simcore_webserver_service in pytest simcore package (#1563)
- add traefik endpoint to api-gateway (#1555)
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants