-
Notifications
You must be signed in to change notification settings - Fork 28
Homogenize studies and services #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1569 +/- ##
=========================================
+ Coverage 61.4% 73.7% +12.2%
=========================================
Files 278 278
Lines 10874 10874
Branches 1181 1181
=========================================
+ Hits 6687 8015 +1328
+ Misses 3875 2516 -1359
- Partials 312 343 +31
|
… into feature/stuvices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, the whole thing a bit confusing. We have studies which are composed by services... and then we can group services to form new studies... but there is a clear separation between services and studies. With these apps, what we do is to create a study that contains only one service, but I don't think that is clear enough for the user. Sorry, I probably missed the discussion about this.
I couldn't test it with a full list of studies as I had trouble migrating the database. What I could test and the code looks good.
MINOR: We you create several studies from the same service, study names duplicate.
node.setProgress(progress); | ||
if (!socket.slotExists(slotName3)) { | ||
socket.on(slotName3, data => { | ||
const d = JSON.parse(data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the server sends json as plain text? it could probably send it as application/json
and then retrieve it client side directly as an object.
if this is not possible, it could be nice to wrap the parsing of the json, and add a try
, as JSON.parse
can also fail
- UI/UX improvements (#1657) - Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665) - Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664) - Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647) - Improving storage performance (#1659) - Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642) - Theming (#1656) - Platform stability: (#1645) - is1594 fix and re-activate e2e testing (#1620) - 2 bugs fixed + Some improvements (#1634) - Fixes default (#1640) - Bump lodash from 4.17.15 to 4.17.19 (#1639) - Is1585/cleanup storage (#1586) - Fixes on publish studies handling (#1632) - Some enhancements and bug fixes (#1608) - Improve e2e (#1631) - filter studies by name before deleting them (#1629) - Maintenance/upgrades test tools (#1628) - Bugfix/concurent opening projects (#1598) - Bugfix/allow reading groups anonymous user (#1615) - Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605) - fix testing if node has gpu support (#1604) - [bugfix] Invalidate cache before starting a study (#1602) - Feature/fix e2e 2 (#1600) - fix deploy not needing e2e testing since it is disabled - reduce cardinality of metrics (#1593) - Excudes e2e stage from include until fixed (#1595) - Shared project concurrency (frontend) (#1591) - Homogenize studies and services (#1569) - [feature] UI Fine grained access - project locking and notification - Bugfix/apiserver does not need sslheaders (#1564) - Cleanup catalog service (#1582) - Maintenance/cleanup api server (#1578) - Adds support for GPU scheduling of computational services (#1553) - Maintenance/upgrades and tooling (#1546) - Is1570/study fails 500 (#1572) - Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573) - maintenance fix codecov reports (#1568) - Manage groups, Share studies (#1512) - Is/add notebook migration script (#1565) - Is1269/api-server upgrade (#1475) - added simcore_webserver_service in pytest simcore package (#1563) - add traefik endpoint to api-gateway (#1555)
What do these changes do?
This PR brings templates closer to services.
The "Services" tab was renamed to "Discover". Under this tab, we list all the available resources (templates and services) to start a new study:
The Studies tab now shows only the studies the logged in user has access to. This list could also be spitted into different sections, such as, "Owned by me", "Shared with me", "Shared with my organizations"...
In addition, the content of the Discover tab is also shipped by the frontend compiler with its own customized navigation bar as standalone application that could be served as the Discover/Explore website.
Bonus:
Related issue number
related to ITISFoundation/osparc-issues#68
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)