Skip to content

Homogenize studies and services #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
Jul 2, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 19, 2020

What do these changes do?

This PR brings templates closer to services.

The "Services" tab was renamed to "Discover". Under this tab, we list all the available resources (templates and services) to start a new study:

  • If a templates is selected, a study containing that pipeline will be initialized (same as before)
  • If a service is selected, a study containing that single node will be initialized (new feature). Since this will be a single node study, the service/app will be automatically maximized. Providing a more app-like user experience.

The Studies tab now shows only the studies the logged in user has access to. This list could also be spitted into different sections, such as, "Owned by me", "Shared with me", "Shared with my organizations"...

In addition, the content of the Discover tab is also shipped by the frontend compiler with its own customized navigation bar as standalone application that could be served as the Discover/Explore website.

Bonus:

  • Clean up:
    • Plotly is not used
    • Removed unused images

Related issue number

related to ITISFoundation/osparc-issues#68

stuvices

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jun 19, 2020
@odeimaiz odeimaiz added this to the Huo Guo milestone Jun 19, 2020
@odeimaiz odeimaiz self-assigned this Jun 19, 2020
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #1569 into master will increase coverage by 12.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1569      +/-   ##
=========================================
+ Coverage    61.4%   73.7%   +12.2%     
=========================================
  Files         278     278              
  Lines       10874   10874              
  Branches     1181    1181              
=========================================
+ Hits         6687    8015    +1328     
+ Misses       3875    2516    -1359     
- Partials      312     343      +31     
Flag Coverage Δ
#integrationtests 56.6% <ø> (ø)
#unittests 67.3% <ø> (+6.4%) ⬆️
Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 63.0% <0.0%> (-0.5%) ⬇️
.../web/server/src/simcore_service_webserver/utils.py 43.1% <0.0%> (+2.2%) ⬆️
...imcore_service_webserver/resource_manager/redis.py 93.7% <0.0%> (+6.2%) ⬆️
...er/src/simcore_service_webserver/login/__init__.py 93.1% <0.0%> (+6.8%) ⬆️
...rc/simcore_service_webserver/application_config.py 100.0% <0.0%> (+7.4%) ⬆️
.../server/src/simcore_service_webserver/login/cfg.py 78.9% <0.0%> (+7.8%) ⬆️
...s/web/server/src/simcore_service_webserver/rest.py 89.5% <0.0%> (+8.3%) ⬆️
...er/src/simcore_service_webserver/catalog_config.py 91.6% <0.0%> (+8.3%) ⬆️
...rver/src/simcore_service_webserver/security_api.py 75.8% <0.0%> (+10.3%) ⬆️
...erver/src/simcore_service_webserver/login/utils.py 52.8% <0.0%> (+11.2%) ⬆️
... and 58 more

@odeimaiz odeimaiz marked this pull request as draft June 19, 2020 11:24
@odeimaiz odeimaiz changed the title WIP: Homogenize studies and services Homogenize studies and services Jun 29, 2020
@odeimaiz odeimaiz marked this pull request as ready for review June 29, 2020 08:56
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the whole thing a bit confusing. We have studies which are composed by services... and then we can group services to form new studies... but there is a clear separation between services and studies. With these apps, what we do is to create a study that contains only one service, but I don't think that is clear enough for the user. Sorry, I probably missed the discussion about this.
I couldn't test it with a full list of studies as I had trouble migrating the database. What I could test and the code looks good.
MINOR: We you create several studies from the same service, study names duplicate.

node.setProgress(progress);
if (!socket.slotExists(slotName3)) {
socket.on(slotName3, data => {
const d = JSON.parse(data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the server sends json as plain text? it could probably send it as application/json and then retrieve it client side directly as an object.
if this is not possible, it could be nice to wrap the parsing of the json, and add a try, as JSON.parse can also fail

@odeimaiz odeimaiz merged commit bb0788f into ITISFoundation:master Jul 2, 2020
@odeimaiz odeimaiz deleted the feature/stuvices branch July 17, 2020 15:45
@odeimaiz odeimaiz mentioned this pull request Aug 4, 2020
odeimaiz added a commit that referenced this pull request Aug 4, 2020
- UI/UX improvements (#1657)
- Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665)
- Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664)
- Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647)
- Improving storage performance (#1659)
- Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642)
- Theming (#1656)
- Platform stability:  (#1645)
- is1594 fix and re-activate e2e testing (#1620)
- 2 bugs fixed + Some improvements (#1634)
- Fixes default (#1640)
- Bump lodash from 4.17.15 to 4.17.19 (#1639)
- Is1585/cleanup storage (#1586)
- Fixes on publish studies handling (#1632)
- Some enhancements and bug fixes (#1608)
- Improve e2e  (#1631)
- filter studies by name before deleting them (#1629)
- Maintenance/upgrades test tools (#1628)
- Bugfix/concurent opening projects (#1598)
- Bugfix/allow reading groups anonymous user (#1615)
- Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605)
- fix testing if node has gpu support (#1604)
- [bugfix] Invalidate cache before starting a study (#1602)
- Feature/fix e2e 2 (#1600)
- fix deploy not needing e2e testing since it is disabled
- reduce cardinality of metrics (#1593)
- Excudes e2e stage from include until fixed (#1595)
- Shared project concurrency (frontend) (#1591)
- Homogenize studies and services (#1569)
- [feature] UI Fine grained access - project locking and notification
- Bugfix/apiserver does not need sslheaders (#1564)
- Cleanup catalog service (#1582)
- Maintenance/cleanup api server (#1578)
- Adds support for GPU scheduling of computational services (#1553)
- Maintenance/upgrades and tooling (#1546)
- Is1570/study fails 500 (#1572)
- Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573)
- maintenance fix codecov reports (#1568)
- Manage groups, Share studies (#1512)
- Is/add notebook migration script (#1565)
- Is1269/api-server upgrade (#1475)
- added simcore_webserver_service in pytest simcore package (#1563)
- add traefik endpoint to api-gateway (#1555)
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants