Skip to content

Fixes on publish studies handling #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 14, 2020

What do these changes do?

  • Fixes various issues found while manual exploratory testing
  • Increases storage and webserver db connection pool

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #1632 into master will decrease coverage by 1.9%.
The diff coverage is 70.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1632     +/-   ##
========================================
- Coverage    75.4%   73.4%   -2.0%     
========================================
  Files         241     257     +16     
  Lines        9868   10517    +649     
  Branches     1066    1166    +100     
========================================
+ Hits         7445    7727    +282     
- Misses       2110    2456    +346     
- Partials      313     334     +21     
Flag Coverage Δ
#integrationtests 56.7% <0.0%> (ø)
#unittests 66.9% <70.0%> (-1.6%) ⬇️
Impacted Files Coverage Δ
...webserver/computation_comp_tasks_listening_task.py 63.1% <0.0%> (ø)
.../director/src/simcore_service_director/producer.py 63.0% <77.7%> (+0.2%) ⬆️
...log/src/simcore_service_catalog/api/routes/meta.py
...catalog/src/simcore_service_catalog/__version__.py
...mcore_service_catalog/api/dependencies/database.py
.../src/simcore_service_catalog/models/schemas/dag.py
...log/src/simcore_service_catalog/api/routes/dags.py
...g/src/simcore_service_catalog/api/routes/health.py
...src/simcore_service_catalog/models/schemas/meta.py
...imcore_service_catalog/db/repositories/__init__.py
... and 51 more

@odeimaiz odeimaiz added this to the Xie-Xie milestone Jul 14, 2020
@pcrespov pcrespov changed the title WIP: Fix misc WIP: Fixes on publish studies handling Jul 14, 2020
@pcrespov pcrespov requested review from odeimaiz and GitHK July 14, 2020 14:00
@pcrespov pcrespov changed the title WIP: Fixes on publish studies handling Fixes on publish studies handling Jul 14, 2020
@pcrespov pcrespov requested review from ignapas and mguidon July 14, 2020 14:01
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit a58c578 into ITISFoundation:master Jul 14, 2020
@pcrespov pcrespov deleted the fix-misc branch July 14, 2020 14:43
@odeimaiz odeimaiz mentioned this pull request Aug 4, 2020
odeimaiz added a commit that referenced this pull request Aug 4, 2020
- UI/UX improvements (#1657)
- Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665)
- Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664)
- Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647)
- Improving storage performance (#1659)
- Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642)
- Theming (#1656)
- Platform stability:  (#1645)
- is1594 fix and re-activate e2e testing (#1620)
- 2 bugs fixed + Some improvements (#1634)
- Fixes default (#1640)
- Bump lodash from 4.17.15 to 4.17.19 (#1639)
- Is1585/cleanup storage (#1586)
- Fixes on publish studies handling (#1632)
- Some enhancements and bug fixes (#1608)
- Improve e2e  (#1631)
- filter studies by name before deleting them (#1629)
- Maintenance/upgrades test tools (#1628)
- Bugfix/concurent opening projects (#1598)
- Bugfix/allow reading groups anonymous user (#1615)
- Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605)
- fix testing if node has gpu support (#1604)
- [bugfix] Invalidate cache before starting a study (#1602)
- Feature/fix e2e 2 (#1600)
- fix deploy not needing e2e testing since it is disabled
- reduce cardinality of metrics (#1593)
- Excudes e2e stage from include until fixed (#1595)
- Shared project concurrency (frontend) (#1591)
- Homogenize studies and services (#1569)
- [feature] UI Fine grained access - project locking and notification
- Bugfix/apiserver does not need sslheaders (#1564)
- Cleanup catalog service (#1582)
- Maintenance/cleanup api server (#1578)
- Adds support for GPU scheduling of computational services (#1553)
- Maintenance/upgrades and tooling (#1546)
- Is1570/study fails 500 (#1572)
- Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573)
- maintenance fix codecov reports (#1568)
- Manage groups, Share studies (#1512)
- Is/add notebook migration script (#1565)
- Is1269/api-server upgrade (#1475)
- added simcore_webserver_service in pytest simcore package (#1563)
- add traefik endpoint to api-gateway (#1555)
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants