Skip to content

Bugfix/apiserver does not need sslheaders #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • sslheader middleware (used for socket.io through traefik) does not like having an hyphen in its name

Related issue number

How to test

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@sanderegg sanderegg added this to the Huo Guo milestone Jun 17, 2020
@sanderegg sanderegg requested review from Surfict, GitHK and pcrespov June 17, 2020 08:48
@sanderegg sanderegg self-assigned this Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1564 into master will decrease coverage by 1.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1564     +/-   ##
========================================
- Coverage    73.4%   72.1%   -1.4%     
========================================
  Files         278     278             
  Lines       10807   10807             
  Branches     1173    1173             
========================================
- Hits         7940    7795    -145     
- Misses       2521    2661    +140     
- Partials      346     351      +5     
Flag Coverage Δ
#integrationtests 56.7% <ø> (ø)
#unittests 70.2% <ø> (+3.1%) ⬆️
Impacted Files Coverage Δ
.../simcore-sdk/src/simcore_sdk/node_data/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...core-sdk/src/simcore_sdk/node_data/data_manager.py 0.0% <0.0%> (-95.3%) ⬇️
...ar/src/simcore_service_sidecar/celery_log_setup.py 0.0% <0.0%> (-69.3%) ⬇️
...src/simcore_service_sidecar/celery_configurator.py 0.0% <0.0%> (-55.4%) ⬇️
...vices/sidecar/src/simcore_service_sidecar/utils.py 53.1% <0.0%> (-36.8%) ⬇️
...ore-sdk/src/simcore_sdk/node_ports/_schema_item.py 87.5% <0.0%> (-12.5%) ⬇️
.../sidecar/src/simcore_service_sidecar/log_parser.py 79.6% <0.0%> (-11.9%) ⬇️
...mcore-sdk/src/simcore_sdk/node_ports/exceptions.py 62.1% <0.0%> (-10.7%) ⬇️
...mcore-sdk/src/simcore_sdk/node_ports/_data_item.py 78.9% <0.0%> (-10.6%) ⬇️
...es/simcore-sdk/src/simcore_sdk/node_ports/_item.py 84.2% <0.0%> (-9.3%) ⬇️
... and 3 more

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOO FOR IT! :-)

@sanderegg sanderegg requested a review from odeimaiz June 19, 2020 06:07
@sanderegg sanderegg merged commit 6b02813 into ITISFoundation:master Jun 30, 2020
@sanderegg sanderegg deleted the bugfix/apiserver_does_not_need_sslheaders branch June 30, 2020 08:14
@odeimaiz odeimaiz mentioned this pull request Aug 4, 2020
odeimaiz added a commit that referenced this pull request Aug 4, 2020
- UI/UX improvements (#1657)
- Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665)
- Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664)
- Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647)
- Improving storage performance (#1659)
- Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642)
- Theming (#1656)
- Platform stability:  (#1645)
- is1594 fix and re-activate e2e testing (#1620)
- 2 bugs fixed + Some improvements (#1634)
- Fixes default (#1640)
- Bump lodash from 4.17.15 to 4.17.19 (#1639)
- Is1585/cleanup storage (#1586)
- Fixes on publish studies handling (#1632)
- Some enhancements and bug fixes (#1608)
- Improve e2e  (#1631)
- filter studies by name before deleting them (#1629)
- Maintenance/upgrades test tools (#1628)
- Bugfix/concurent opening projects (#1598)
- Bugfix/allow reading groups anonymous user (#1615)
- Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605)
- fix testing if node has gpu support (#1604)
- [bugfix] Invalidate cache before starting a study (#1602)
- Feature/fix e2e 2 (#1600)
- fix deploy not needing e2e testing since it is disabled
- reduce cardinality of metrics (#1593)
- Excudes e2e stage from include until fixed (#1595)
- Shared project concurrency (frontend) (#1591)
- Homogenize studies and services (#1569)
- [feature] UI Fine grained access - project locking and notification
- Bugfix/apiserver does not need sslheaders (#1564)
- Cleanup catalog service (#1582)
- Maintenance/cleanup api server (#1578)
- Adds support for GPU scheduling of computational services (#1553)
- Maintenance/upgrades and tooling (#1546)
- Is1570/study fails 500 (#1572)
- Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573)
- maintenance fix codecov reports (#1568)
- Manage groups, Share studies (#1512)
- Is/add notebook migration script (#1565)
- Is1269/api-server upgrade (#1475)
- added simcore_webserver_service in pytest simcore package (#1563)
- add traefik endpoint to api-gateway (#1555)
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants