Shared project concurrency (frontend) #1591

odeimaiz · 2020-07-01T07:36:24Z

What do these changes do?

This PR brings the frontend functionalities for the Shared project concurrency #1576.

Study cards show lock and tooltip when study is being used somewhere else
Optimized backend calls for getting Orgs and orgMembers

Related issue number

related to ITISFoundation/osparc-issues#22

How to test

Checklist

Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
Unit tests for the changes exist
Runs in the swarm
Documentation reflects the changes
New module? Add your github username to .github/CODEOWNERS

added test for groups access rights

GitHK

👍 I just don't like the mouse pointer, but that's just me.

.github/workflows/ci-testing-deploy.yml

ignapas

I could open the study in both windows by quickly clicking on the buttons. Then both users can modify the study at the same time with no error. And it is possible on only one window, to go back to the dashboard and inside the study again (no blocking even if the other window still has the study opened)

odeimaiz · 2020-07-02T13:28:26Z

I could open the study in both windows by quickly clicking on the buttons. Then both users can modify the study at the same time with no error. And it is possible on only one window, to go back to the dashboard and inside the study again (no blocking even if the other window still has the study opened)

Yep, good catch! I was also able to reproduce it.

Unfortunately, this is a bug in the backend and this PR only provides the frontend for the existing backend. Could you please crate a bug case and assign it to @sanderegg ?

discussed

GitHK · 2020-07-02T13:42:55Z

I could open the study in both windows by quickly clicking on the buttons. Then both users can modify the study at the same time with no error. And it is possible on only one window, to go back to the dashboard and inside the study again (no blocking even if the other window still has the study opened)

Yep, good catch! I was also able to reproduce it.

Unfortunately, this is a bug in the backend and this PR only provides the frontend for the existing backend. Could you please crate a bug case and assign it to @sanderegg ?

Also please tag me in the discussion I might know what happened.

ignapas

🆗 client part... with some concerns: #1596

- UI/UX improvements (#1657) - Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665) - Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664) - Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647) - Improving storage performance (#1659) - Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642) - Theming (#1656) - Platform stability: (#1645) - is1594 fix and re-activate e2e testing (#1620) - 2 bugs fixed + Some improvements (#1634) - Fixes default (#1640) - Bump lodash from 4.17.15 to 4.17.19 (#1639) - Is1585/cleanup storage (#1586) - Fixes on publish studies handling (#1632) - Some enhancements and bug fixes (#1608) - Improve e2e (#1631) - filter studies by name before deleting them (#1629) - Maintenance/upgrades test tools (#1628) - Bugfix/concurent opening projects (#1598) - Bugfix/allow reading groups anonymous user (#1615) - Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605) - fix testing if node has gpu support (#1604) - [bugfix] Invalidate cache before starting a study (#1602) - Feature/fix e2e 2 (#1600) - fix deploy not needing e2e testing since it is disabled - reduce cardinality of metrics (#1593) - Excudes e2e stage from include until fixed (#1595) - Shared project concurrency (frontend) (#1591) - Homogenize studies and services (#1569) - [feature] UI Fine grained access - project locking and notification - Bugfix/apiserver does not need sslheaders (#1564) - Cleanup catalog service (#1582) - Maintenance/cleanup api server (#1578) - Adds support for GPU scheduling of computational services (#1553) - Maintenance/upgrades and tooling (#1546) - Is1570/study fails 500 (#1572) - Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573) - maintenance fix codecov reports (#1568) - Manage groups, Share studies (#1512) - Is/add notebook migration script (#1565) - Is1269/api-server upgrade (#1475) - added simcore_webserver_service in pytest simcore package (#1563) - add traefik endpoint to api-gateway (#1555)

sanderegg added 30 commits June 23, 2020 09:35

write permissions needed to remove a user not delete permission

ae34618

adding group testing with more than 1 user

2d8149b

small fixes

61f9261

fixing user in group patch endpoint

2922a55

fix patch users in group endpoint

890a9bc

access_rights renamed to accessRights

fd8f0d4

renamed access_rights to accessRights following openapi

cec68fa

fix rename access_rights to accessRights

782d95d

added test for groups access rights

simplify tests

307d3c2

refactor

b2b7641

added test for opening a shared project 2 times

91da8b7

moved helpers in a module

b91cf46

simplify tests

74dd47f

refactor

e0f0a5b

ongoing tests

40f27e0

missing import

09b6e11

adding test for shared project concurrency

7b54a98

test ready for concurrency access

df4c404

after user 1 closes the project user 2 shall be able to open

3fceb21

prevent opening of same project by 2 users

5d90377

typos

c579d75

wrong syntax

93f336a

typo

003dac7

fixed test

d36b081

added endpoint to return state of a project

d14811e

adding state endpoint

17e6c6f

fixed endpoint behaviour

ddcccda

Merge branch 'master' into is/shared_project_concurrency2

2dc23c3

refactor

84f181b

mypy

fdd540b

odeimaiz added 3 commits July 2, 2020 10:52

new state object

86a8ce4

minor

caca98d

minor

776db3a

odeimaiz changed the title ~~WIP: Shared project concurrency~~ Shared project concurrency (frontend) Jul 2, 2020

odeimaiz requested review from sanderegg, ignapas, GitHK and pcrespov and removed request for sanderegg July 2, 2020 09:10

GitHK approved these changes Jul 2, 2020

View reviewed changes

skip system-test-e2e

f196851

pcrespov reviewed Jul 2, 2020

View reviewed changes

.github/workflows/ci-testing-deploy.yml Outdated Show resolved Hide resolved

fixme added

314dfcf

ignapas previously requested changes Jul 2, 2020

View reviewed changes

odeimaiz requested review from pcrespov and ignapas July 2, 2020 13:28

odeimaiz added 3 commits July 2, 2020 16:22

Merge branch 'master' into sanderegg-is/shared_project_concurrency2

a366f75

minor

f3a3654

minor fixes

38241ad

ignapas mentioned this pull request Jul 2, 2020

Two different clients can edit same study at the same time #1596

Closed

ignapas approved these changes Jul 2, 2020

View reviewed changes

odeimaiz merged commit cb0094b into ITISFoundation:master Jul 2, 2020

odeimaiz deleted the sanderegg-is/shared_project_concurrency2 branch July 17, 2020 15:45

odeimaiz mentioned this pull request Aug 4, 2020

FREEZE_XieXie #1669

Merged

sanderegg mentioned this pull request Aug 21, 2020

FREEZE_DaJia1 #1733

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shared project concurrency (frontend) #1591

Shared project concurrency (frontend) #1591

odeimaiz commented Jul 1, 2020 •

edited

Loading

GitHK left a comment

ignapas left a comment •

edited

Loading

odeimaiz commented Jul 2, 2020

GitHK commented Jul 2, 2020

ignapas left a comment

Shared project concurrency (frontend) #1591

Shared project concurrency (frontend) #1591

Conversation

odeimaiz commented Jul 1, 2020 • edited Loading

What do these changes do?

Related issue number

How to test

Checklist

GitHK left a comment

Choose a reason for hiding this comment

ignapas left a comment • edited Loading

Choose a reason for hiding this comment

odeimaiz commented Jul 2, 2020

GitHK commented Jul 2, 2020

ignapas left a comment

Choose a reason for hiding this comment

odeimaiz commented Jul 1, 2020 •

edited

Loading

ignapas left a comment •

edited

Loading