-
Notifications
You must be signed in to change notification settings - Fork 28
Cleanup catalog service #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup catalog service #1582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
========================================
+ Coverage 72.6% 73.4% +0.8%
========================================
Files 271 278 +7
Lines 10721 10807 +86
Branches 1172 1173 +1
========================================
+ Hits 7790 7940 +150
+ Misses 2586 2521 -65
- Partials 345 346 +1
|
- api/dependencies: dependencies injected in handlers - api/routes: endpoint handlers and routing - api/root.py: join all openapi-specs into a single router - models: domain (orm and business logic models) and schema (i/o schemas for openapi) models - db: database tables (i.e. sa schemas for tables) and repositories (crud layer between handlers and db calls) - core: init application and settings (parses values by args, environs, .env or default, in this order) - services: modules/plugins with logic for the app - __main__,__version__ : main entrypoint and version
'Defining 'pytest_plugins' in a non-top-level conftest is no longer supported'
3f76655
to
835089b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Is the DAG part of this service used only for parsing the workbench?
@GitHK, a DAG is an "work-in-progress" data structure to define projects with workbench of hierarchical graphs, i.e. graphs can also embed graphs in its nodes. These nodes that "contain" a graph is what some people here call "macro" services |
- UI/UX improvements (#1657) - Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665) - Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664) - Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647) - Improving storage performance (#1659) - Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642) - Theming (#1656) - Platform stability: (#1645) - is1594 fix and re-activate e2e testing (#1620) - 2 bugs fixed + Some improvements (#1634) - Fixes default (#1640) - Bump lodash from 4.17.15 to 4.17.19 (#1639) - Is1585/cleanup storage (#1586) - Fixes on publish studies handling (#1632) - Some enhancements and bug fixes (#1608) - Improve e2e (#1631) - filter studies by name before deleting them (#1629) - Maintenance/upgrades test tools (#1628) - Bugfix/concurent opening projects (#1598) - Bugfix/allow reading groups anonymous user (#1615) - Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605) - fix testing if node has gpu support (#1604) - [bugfix] Invalidate cache before starting a study (#1602) - Feature/fix e2e 2 (#1600) - fix deploy not needing e2e testing since it is disabled - reduce cardinality of metrics (#1593) - Excudes e2e stage from include until fixed (#1595) - Shared project concurrency (frontend) (#1591) - Homogenize studies and services (#1569) - [feature] UI Fine grained access - project locking and notification - Bugfix/apiserver does not need sslheaders (#1564) - Cleanup catalog service (#1582) - Maintenance/cleanup api server (#1578) - Adds support for GPU scheduling of computational services (#1553) - Maintenance/upgrades and tooling (#1546) - Is1570/study fails 500 (#1572) - Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573) - maintenance fix codecov reports (#1568) - Manage groups, Share studies (#1512) - Is/add notebook migration script (#1565) - Is1269/api-server upgrade (#1475) - added simcore_webserver_service in pytest simcore package (#1563) - add traefik endpoint to api-gateway (#1555)
What do these changes do?
Cleanup of catalog service before adding more functionality
api/dependencies
: dependencies injected in handlersapi/routes
: endpoint handlers and routingapi/root.py
: joins all openapi-specs into a single routermodels
: domain (orm and business logic models) and schema (i/o schemas for openapi) modelsdb
: database tables (i.e. sa schemas for tables) and repositories (crud layer between handlers and db calls)core
: init application and settings (parses values by args, environs, .env or default, in this order)services
: modules/plugins with logic for the app__main__,__version__
: main entrypoint and versionSome extra changes repo-wise
${PYTHON_VERSION}-slim
to${PYTHON_VERSION}-slim-buster
pytest_simcore.postgres_service2
that migrates database on the flyHow to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)